Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fbe/sol token swap #107

Closed
wants to merge 1 commit into from
Closed

Fbe/sol token swap #107

wants to merge 1 commit into from

Conversation

fbeutin-ledger
Copy link

Implement SPL swap

yogh333
yogh333 requested changes Jan 16, 2025
View reviewed changes
Copy link

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except two little comments

libsol/util.h Show resolved Hide resolved
src/swap/handle_swap_sign_transaction.c Show resolved Hide resolved
bboilot-ledger
bboilot-ledger requested changes Jan 22, 2025
View reviewed changes
Copy link

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the CI seems to fail because of lint issue. Would be nice to fix it (can be done inside the next PR as we'll merge all of them).

src/swap/handle_check_address.c Show resolved Hide resolved
src/handle_sign_message.c Show resolved Hide resolved
@fbeutin-ledger
Copy link
Author

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboilot-ledger bboilot-ledger bboilot-ledger requested changes

@yogh333 yogh333 yogh333 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeutin-ledger @yogh333 @bboilot-ledger